JS errors after install

Anonymous

#155214

Hi,

I wanted to test your plugin for a website I’m developing but I’m getting 2 JS errors. Can you help please?

Warning: Illegal string offset ‘results_url’ in ‘class-search-filter-helper.php’ on line 235

Warning: Cannot assign an empty string to a string offset in ‘class-search-filter-helper.php’ on line 235

Thank you!

Ross Moderator

#155340

Hi Thomas

These are actually PHP warnings and have been fixed in our next version. Release is today/tomorrow so watch out for it and let me know if you are still having issues.

Thanks

Anonymous

#155374

Yes, sorry, I was working on some JS at the same time so I got confused. Anyway, awaiting the new version then.

By the way, is there any easy to get rid of of the “Found x results” and page number without messing with the plugin code? I wish there was some html markup for these in future version, so they could easily be hidden using CSS.

Trevor

#155381

If you are using the Shortcode Display Results Method, you can edit the result.php template file. See here for the documentation:

https://www.designsandcode.com/documentation/search-filter-pro/search-results/using-a-shortcode/#Customising_the_Results

Also note that we have now officially released 2.4.0 of Search & Filter Pro.

Anonymous

#155389

OK that’s really weird. I’m indeed using a custom template, but based on the infinity scroll one (my search forms are all set to infinity scroll).

So I had cleaned the unwanted parts from that template, but not from the “standard” results template. I just did it and it worked. So, somehow, the plugin is still using the results template despite being set to use the infinity one.

Any idea of what could be causing this?

Trevor

#155392

If you want to use the infinite scroll template, you must rename it to results.php and put it in the child theme folder. Did you do that?

Anonymous

#155394

Oooops, no, I’m using both templates in the child theme folder. I’ll try now.

Many thanks for the help!

Trevor

#155405

If you read through that link I sent you, it explains where to put the files. It is to stop any updates overwriting your own code.

Anonymous

#155683

Hi again Trevor,

It seems like I just found a bug with the new version of your plugin.

It’s pretty difficult to explain, but it seems that any taxonomy added since the new version works, but when put in a page template messes around with the Visual Composer elements below it. You can see an example here:

– This page has a full-width footer built with Visual Composer. It displays in full width as it should, and the main container ends with a shortcode using a taxonomy (tag of the Download Monitor’s custom post type) created before the new version of the plugin: http://atee.education/rd-communities/professional-development/
– This page, on the other hand, has pretty much the same search form but with a tag created after I updated the plugin. See the footer? It doesn’t take into account the rule set for the VC row to display in full-width. If I change the search form to another tag, then it works again! – http://atee.education/rd-communities/health-environment-and-sustainability/

Do you understand what’s happening here?

Trevor

#155736

This reply has been marked as private.

[Author]

Posts