- This topic has 6 replies, 2 voices, and was last updated 10 years, 6 months ago by
.
Viewing 7 posts – 1 through 7 (of 7 total)
Viewing 7 posts – 1 through 7 (of 7 total)
not working after upgrade
Posted
by
Posted
by
Forums › Forums › Search & Filter Pro › not working after upgrade
Tagged: not working after upgrade
Ross.
hi guys
after finally sorting out my manual ftp upgrade – search and filter pro has broken down in a big way 🙁
display results layout is completely messed up – and the results of any search are returning everything despite there being no relation to the search terms.
can you send me a link to the previous version – i will get round to fixing this but i don’t have the time at the minute, so i’m gonna have to downgrade.
feel free to offer some advice because this just isn’t working for me: i’ve tried numerous display results as options – none work!
http://eastendvintageglamour.org.uk/search/
thanks
Hey Jason
Did you read the 2.0 upgrade notes? http://www.designsandcode.com/documentation/search-filter-pro/2-0-upgrade-notes/
There might be some handy hints in there…
After you’ve tried that let me know and we can take a look further.
Thanks
hi ross
yep i’d checked those notes and have set up a new form on http://eastendvintageglamour.org.uk/search/ but basically any search is just returning results that have no bearing on the terms or selections. even searching something i know doesn’t exist – or if i specifically know does..?
Hi Jason
The issue with S&F is that you are loading jQuery twice, which should not be done regardless of the S&F error – see the first copy on line 39 –
<script type='text/javascript' src='http://eastendvintageglamour.org.uk/wp-includes/js/jquery/jquery.js?ver=1.12.3'></script> version 1.12.3
And then also on line 111
<script type="text/javascript" src="//code.jquery.com/jquery-1.11.0.min.js"></script>
So, you are loading an old version of jquery on top of a newer one (comes with WP 4.5)
There is absolutely no need for the second instance, and if removing the second instance breaks things, then that will be because your plugin does not support WP 4.5 yet – so you must fix this first to proceed.
In terms of bad practice, well really its a bad idea.
First, your users’ make 2 requests for the jQuery files, then they have the overhead of the download size (jQuery is a big library), and then there is also initialisation…
On top of that you have them occupying the same namespace, and in the case of S&F, overwriting itself, so S&F so it no longer exists on the new copy…
These are just some of the issues.
If you absolutely must load two versions, you should use noconflict mode:
http://stackoverflow.com/questions/1566595/can-i-use-multiple-versions-of-jquery-on-the-same-page
Thanks